Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2770193004: (reland) Use stricter checking in UrlOverridingTest (Closed)

Created:
3 years, 9 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
Maria
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

(reland) Use stricter checking in UrlOverridingTest Check the callback counts in all the test cases, and wait for the fallback navigation to avoid early abortion. The failures with PlzNavigate are not fixed yet. BUG=699388 Review-Url: https://codereview.chromium.org/2770193004 Cr-Commit-Position: refs/heads/master@{#464316} Committed: https://chromium.googlesource.com/chromium/src/+/1e31d646391e0b4a897025d83a4d7ba5fdbbc175

Patch Set 1 : import https://codereview.chromium.org/2763843002/ #

Patch Set 2 : fix tablet #

Patch Set 3 : fix merging, better error msg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java View 1 2 6 chunks +36 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
wychen
PTAL
3 years, 8 months ago (2017-04-12 01:10:29 UTC) #4
Maria
lgtm
3 years, 8 months ago (2017-04-12 17:16:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770193004/60001
3 years, 8 months ago (2017-04-13 05:19:59 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 06:19:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1e31d646391e0b4a897025d83a4d...

Powered by Google App Engine
This is Rietveld 408576698