Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2770153002:
MD Settings: fix input label floating around for search field. (Closed)
|
Created:
3 years, 9 months ago by scottchen Modified:
3 years, 8 months ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: fix input label floating around for search field.
BUG=704434
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2770153002
Cr-Commit-Position: refs/heads/master@{#459627}
Committed: https://chromium.googlesource.com/chromium/src/+/466023119ab84e9d0b54af4fad4a32c72f7092a0
Patch Set 1 #Patch Set 2 : merge #Messages
Total messages: 19 (13 generated)
Description was changed from ========== MD Settings: fix input label floating around for search field. BUG=704434 ========== to ========== MD Settings: fix input label floating around for search field. BUG=704434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
scottchen@chromium.org changed reviewers: + dpapad@chromium.org
screenshot after fix: http://imgur.com/a/GApRu (before ss in bug report)
The CQ bit was checked by scottchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by scottchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2770153002/#ps20001 (title: "merge")
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490398502008710,
"parent_rev": "4772a46e8ad389ccddacf46ab84cd0212e60b86d", "commit_rev":
"466023119ab84e9d0b54af4fad4a32c72f7092a0"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: fix input label floating around for search field. BUG=704434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: fix input label floating around for search field. BUG=704434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2770153002 Cr-Commit-Position: refs/heads/master@{#459627} Committed: https://chromium.googlesource.com/chromium/src/+/466023119ab84e9d0b54af4fad4a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/466023119ab84e9d0b54af4fad4a... |
