DevTools: produce javascript outline for javascript classess

DevTools: produce javascript outline for javascript classess

This patch moves javascript outline from tokenizer to the AST
builder. In order to support partially-valid javascript, the
acorn_loose third-party lib is added for AST parsing recovery.

This patch also moves acorn into its own module, 'acorn', and
makes formatted_worker depend on it.

BUG=438203
R=dgozman

Review-Url: https://codereview.chromium.org/2770123002
Cr-Commit-Position: refs/heads/master@{#459647}
Committed: https://chromium.googlesource.com/chromium/src/+/4e07322ab36c46688f4ac15ccc8ac7570b46bd78

[lushnikov, 2017-03-23 21:25:38]

please, take a look.

This patch will add 37Kb to devtools bundle, since it's adding acorn_loosy as a
non-remote module. The motivation behind this is that outline functionality is a
core-level functionality for the devtools. Given the recent savings on image
cleanups we had in January, +37Kb might not be that horrible.

[lushnikov, 2017-03-23 21:27:34]

One more thing: this patch depends on two patches
- text_utils module https://codereview.chromium.org/2769843003/
- js outline tests  https://codereview.chromium.org/2771623003/

[dgozman, 2017-03-24 01:00:01]

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger/script-extract-outline-expected.txt
(right):

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger/script-extract-outline-expected.txt:27:
name : "Object.prototype.functionOnPrototype"
Let's revert this.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-4-expected.txt
(right):

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-4-expected.txt:4:
Running: testAsyncFunction
Add testAsyncArrowFunction

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/acorn/module.json (right):

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/acorn/module.json:2: "scripts": [
Let's move it back.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js
(right):

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:41:
(node.type === 'MethodDefinition' || node.type === 'Property') &&
isIdentifier(node.key) &&
String literal as a computed property key.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:42:
isFunctionNode(node.value)) {
Property could be a class.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:92:
function isIdentifier(node) {
isName

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:95:
return node.type === 'Identifier' || node.type === 'MemberExpression';
&& !node.computed

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:123:
path.push(node.property.name);
Cannot get property "name" of undefined

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:126:
console.assert(node.type === 'Identifier', 'Cannot extract identifier from
unknown type: ' + node.type);
(a || b).c = 2;

[lushnikov, 2017-03-24 19:19:37]

All done. Also, killed redundant script-extract-outline test, since all cases
are covered by outline-javascript* tests.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger/script-extract-outline-expected.txt
(right):

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger/script-extract-outline-expected.txt:27:
name : "Object.prototype.functionOnPrototype"
On 2017/03/24 01:00:00, dgozman wrote:
> Let's revert this.

Done.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-4-expected.txt
(right):

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-4-expected.txt:4:
Running: testAsyncFunction
On 2017/03/24 01:00:00, dgozman wrote:
> Add testAsyncArrowFunction

Done.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js
(right):

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:41:
(node.type === 'MethodDefinition' || node.type === 'Property') &&
isIdentifier(node.key) &&
On 2017/03/24 01:00:00, dgozman wrote:
> String literal as a computed property key.

Done.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:42:
isFunctionNode(node.value)) {
On 2017/03/24 01:00:00, dgozman wrote:
> Property could be a class.

Done.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:92:
function isIdentifier(node) {
On 2017/03/24 01:00:00, dgozman wrote:
> isName

Done.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:95:
return node.type === 'Identifier' || node.type === 'MemberExpression';
On 2017/03/24 01:00:00, dgozman wrote:
> && !node.computed

Done.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:123:
path.push(node.property.name);
On 2017/03/24 01:00:00, dgozman wrote:
> Cannot get property "name" of undefined

Done.

https://codereview.chromium.org/2770123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptOutline.js:126:
console.assert(node.type === 'Identifier', 'Cannot extract identifier from
unknown type: ' + node.type);
On 2017/03/24 01:00:00, dgozman wrote:
> (a || b).c = 2;

Done.

[lushnikov, 2017-03-24 19:19:49]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 19:20:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:01:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 21:01:22]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-03-24 23:07:31]

lgtm

https://codereview.chromium.org/2770123002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-5-expected.txt
(right):

https://codereview.chromium.org/2770123002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-5-expected.txt:25:
"bar"():0:12
Let's drop this and next one

https://codereview.chromium.org/2770123002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-6-expected.txt
(right):

https://codereview.chromium.org/2770123002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-6-expected.txt:8:
class 42:0:12
let's instead support { abc: class }

[lushnikov, 2017-03-25 06:38:34]

all done, thanks!

https://codereview.chromium.org/2770123002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-5-expected.txt
(right):

https://codereview.chromium.org/2770123002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-5-expected.txt:25:
"bar"():0:12
On 2017/03/24 23:07:30, dgozman wrote:
> Let's drop this and next one

Done.

https://codereview.chromium.org/2770123002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-6-expected.txt
(right):

https://codereview.chromium.org/2770123002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-6-expected.txt:8:
class 42:0:12
On 2017/03/24 23:07:30, dgozman wrote:
> let's instead support { abc: class }

Done.

[lushnikov, 2017-03-25 06:38:55]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-03-25 06:38:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2770123002/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2017-03-25 06:39:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 09:14:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490423935494280,
"parent_rev": "3a17f21225fc435f31e588292073eab3e4952502", "commit_rev":
"4e07322ab36c46688f4ac15ccc8ac7570b46bd78"}

[commit-bot: I haz the power, 2017-03-25 09:15:58]

Description was changed from

==========
DevTools: produce javascript outline for javascript classess

This patch moves javascript outline from tokenizer to the AST
builder. In order to support partially-valid javascript, the
acorn_loose third-party lib is added for AST parsing recovery.

This patch also moves acorn into its own module, 'acorn', and
makes formatted_worker depend on it.

BUG=438203
R=dgozman
==========

to

==========
DevTools: produce javascript outline for javascript classess

This patch moves javascript outline from tokenizer to the AST
builder. In order to support partially-valid javascript, the
acorn_loose third-party lib is added for AST parsing recovery.

This patch also moves acorn into its own module, 'acorn', and
makes formatted_worker depend on it.

BUG=438203
R=dgozman

Review-Url: https://codereview.chromium.org/2770123002
Cr-Commit-Position: refs/heads/master@{#459647}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e07322ab36c46688f4ac15ccc8a...
==========

[commit-bot: I haz the power, 2017-03-25 09:15:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4e07322ab36c46688f4ac15ccc8a...