Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2770093003: Add test for QCMS based color transforms (Closed)

Created:
3 years, 9 months ago by ccameron
Modified:
3 years, 9 months ago
Reviewers:
msarett, msarett1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for QCMS based color transforms Landing this before chaning from QCMS to SkColorSpaceXform, to ensure that the resulst are unchanged. BUG= Review-Url: https://codereview.chromium.org/2770093003 Cr-Commit-Position: refs/heads/master@{#459523} Committed: https://chromium.googlesource.com/chromium/src/+/3ada34d124025e8fc31c7535edc2bc7195c55bfa

Patch Set 1 #

Patch Set 2 : Really add the tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M ui/gfx/color_transform_unittest.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
This CL has an open dependency (Issue 2769863003 Patch 80001). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-24 04:44:16 UTC) #3
msarett1
lgtm
3 years, 9 months ago (2017-03-24 12:55:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770093003/20001
3 years, 9 months ago (2017-03-24 19:16:46 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 19:40:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3ada34d124025e8fc31c7535edc2...

Powered by Google App Engine
This is Rietveld 408576698