Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2770043003: Refactor V8PrivateProperty to use an array.

Created:
3 years, 9 months ago by jbroman
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor V8PrivateProperty to use an array. This makes using it generically easier. BUG=

Patch Set 1 #

Patch Set 2 : factor a bunch of stuff out of the macro #

Patch Set 3 : remove obsolete macro #

Patch Set 4 : move the DCHECK before the indexing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -31 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 1 2 3 3 chunks +28 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (12 generated)
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-23 23:28:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770043003/1
3 years, 9 months ago (2017-03-23 23:29:38 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-23 23:40:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770043003/20001
3 years, 9 months ago (2017-03-23 23:41:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-24 01:27:16 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 9 months ago (2017-03-24 01:27:17 UTC) #6
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-24 01:58:32 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770043003/40001
3 years, 9 months ago (2017-03-24 01:58:44 UTC) #8
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-24 02:21:36 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770043003/60001
3 years, 9 months ago (2017-03-24 02:21:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-24 03:09:12 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 03:09:13 UTC) #12 
Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698