Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2770023003: Improve performance of rebaselining after TestBaselineSet change. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
wkorman
CC:
blink-reviews, chromium-reviews, drott
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve performance of rebaselining after TestBaselineSet change. After https://codereview.chromium.org/2765863003, performance of webkit-patch rebaseline-cl when rebaselining many tests regressed, and there were a couple places where it looks like the code was repeating work unnecessarily. BUG=702819 Review-Url: https://codereview.chromium.org/2770023003 Cr-Commit-Position: refs/heads/master@{#459191} Committed: https://chromium.googlesource.com/chromium/src/+/a75871227d372a8b0ddd0638a075b56eff4f7380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 5 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 9 months ago (2017-03-23 18:04:59 UTC) #2
wkorman
lgtm
3 years, 9 months ago (2017-03-23 18:28:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770023003/1
3 years, 9 months ago (2017-03-23 18:38:13 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 20:08:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a75871227d372a8b0ddd0638a075...

Powered by Google App Engine
This is Rietveld 408576698