Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2770013003: Switch from "winio" to "npipe". (Closed)

Created:
3 years, 9 months ago by dnj
Modified:
3 years, 9 months ago
Reviewers:
iannucci1, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Switch from "winio" to "npipe". This is a hopeful fix to the linked bug. The problem is Go runtime panic that manifested in coordination with an upgrade to Go 1.8. There are several GitHub issue threads referencing similar issues with Windows and "winio". We have to disable the test because "npipe" is actually not a fully- correct Go Listener implementation, and the test fails because of this. This is okay, though, as this code has run for quite a while on Windows using "npipe" without issue. BUG=chromium:702105 TEST=None R=vadimsh@chromium.org Review-Url: https://codereview.chromium.org/2770013003 Committed: https://github.com/luci/luci-go/commit/6cb138dd7f4d900c66b22f22b9bbde1b0c4ff975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M logdog/client/butler/streamserver/namedPipe_windows.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/butler/streamserver/namedPipe_windows_test.go View 1 chunk +3 lines, -1 line 0 comments Download
M logdog/client/butlerlib/streamclient/client_namedPipe_windows.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dnj
3 years, 9 months ago (2017-03-24 02:03:19 UTC) #1
iannucci1
lgtm
3 years, 9 months ago (2017-03-24 02:03:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770013003/1
3 years, 9 months ago (2017-03-24 02:04:01 UTC) #5
Vadim Sh.
lgtm
3 years, 9 months ago (2017-03-24 02:04:19 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 02:10:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/6cb138dd7f4d900c66b22f22b9bbde1b0c4ff975

Powered by Google App Engine
This is Rietveld 408576698