content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java - Issue 2769993002: Restrict getInstalledRelatedApps() to non-incognito contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java

Issue 2769993002: Restrict getInstalledRelatedApps() to non-incognito contexts. (Closed)

Patch Set: fix variable name + todo Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java ('k') | content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java b/content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java

index 82bf8be2a8d6c3bd4dea4761cf4a2d89649379d3..6eda1a32f02735d6e74e5891582a5320ecf9b422 100644

--- a/content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java

+++ b/content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java

@@ -5,6 +5,7 @@

package org.chromium.content.browser.installedapp;

import org.chromium.base.ContextUtils;

+import org.chromium.content.browser.framehost.RenderFrameHostImpl;

import org.chromium.content_public.browser.RenderFrameHost;

import org.chromium.installedapp.mojom.InstalledAppProvider;

import org.chromium.services.service_manager.InterfaceFactory;

@@ -18,10 +19,10 @@ public class InstalledAppProviderFactory implements InterfaceFactory<InstalledAp

private static final class FrameUrlDelegateImpl

implements InstalledAppProviderImpl.FrameUrlDelegate {

- private final RenderFrameHost mRenderFrameHost;

+ private final RenderFrameHostImpl mRenderFrameHost;

public FrameUrlDelegateImpl(RenderFrameHost renderFrameHost) {

- mRenderFrameHost = renderFrameHost;

+ mRenderFrameHost = (RenderFrameHostImpl) renderFrameHost;

}

@Override

@@ -35,6 +36,11 @@ public class InstalledAppProviderFactory implements InterfaceFactory<InstalledAp

throw new AssertionError(e);

}

+ @Override

+ public boolean isIncognito() {

+ return mRenderFrameHost.isIncognito();

+ }

}

public InstalledAppProviderFactory(RenderFrameHost renderFrameHost) {