Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java

Issue 2769993002: Restrict getInstalledRelatedApps() to non-incognito contexts. (Closed)
Patch Set: fix variable name + todo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java b/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
index 8a4526a9a0023c99a706b9662c0d5bcff0037ffd..3514a2d8045b1ac3660c4f29a936d2ddbcd11352 100644
--- a/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
@@ -17,17 +17,19 @@ public class RenderFrameHostImpl implements RenderFrameHost {
private long mNativeRenderFrameHostAndroid;
// mDelegate can be null.
final RenderFrameHostDelegate mDelegate;
+ final boolean mIncognito;
- private RenderFrameHostImpl(
- long nativeRenderFrameHostAndroid, RenderFrameHostDelegate delegate) {
+ private RenderFrameHostImpl(long nativeRenderFrameHostAndroid, RenderFrameHostDelegate delegate,
+ boolean isIncognito) {
mNativeRenderFrameHostAndroid = nativeRenderFrameHostAndroid;
mDelegate = delegate;
+ mIncognito = isIncognito;
}
@CalledByNative
- private static RenderFrameHostImpl create(
- long nativeRenderFrameHostAndroid, RenderFrameHostDelegate delegate) {
- return new RenderFrameHostImpl(nativeRenderFrameHostAndroid, delegate);
+ private static RenderFrameHostImpl create(long nativeRenderFrameHostAndroid,
+ RenderFrameHostDelegate delegate, boolean isIncognito) {
+ return new RenderFrameHostImpl(nativeRenderFrameHostAndroid, delegate, isIncognito);
}
@CalledByNative
@@ -50,5 +52,16 @@ public class RenderFrameHostImpl implements RenderFrameHost {
return nativeGetLastCommittedURL(mNativeRenderFrameHostAndroid);
}
+ /**
+ * Returns whether we're in incognito mode.
+ *
+ * TODO(timloh): This function shouldn't really be on here. If we end up
+ * needing more logic from the native BrowserContext, we should add a
+ * wrapper for that and move this function there.
+ */
+ public boolean isIncognito() {
+ return mIncognito;
+ }
+
private native String nativeGetLastCommittedURL(long nativeRenderFrameHostAndroid);
}

Powered by Google App Engine
This is Rietveld 408576698