Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2769973005: [JSPerfTests] New tests for Array.prototype.filter and map. (Closed)

Created:
3 years, 9 months ago by mvstanton
Modified:
3 years, 9 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[JSPerfTests] New tests for Array.prototype.filter and map. BUG= Review-Url: https://codereview.chromium.org/2769973005 Cr-Commit-Position: refs/heads/master@{#44115} Committed: https://chromium.googlesource.com/v8/v8/+/7e08a77debc401d62c4a7ffef79fe9c2f3d8a204

Patch Set 1 #

Patch Set 2 : Naive tests go generic. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -51 lines) Patch
M test/js-perf-test/Array/filter.js View 1 3 chunks +49 lines, -45 lines 0 comments Download
A test/js-perf-test/Array/map.js View 1 1 chunk +88 lines, -0 lines 0 comments Download
M test/js-perf-test/Array/run.js View 2 chunks +2 lines, -4 lines 0 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mvstanton
Hi Danno, Here are some tests for a few array builtins. Thanks for the look. ...
3 years, 9 months ago (2017-03-24 14:35:03 UTC) #2
danno
lgtm
3 years, 9 months ago (2017-03-24 14:36:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769973005/20001
3 years, 9 months ago (2017-03-24 14:43:09 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 17:39:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/7e08a77debc401d62c4a7ffef79fe9c2f3d...

Powered by Google App Engine
This is Rietveld 408576698