Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2769973002: Disable 6 history UI tests. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 9 months ago
Reviewers:
jif
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org, edchin, lpromero
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable 6 history UI tests. The following tests have been failing on iPad and iPhone: HistoryUITestCase.testDisplayHistory HistoryUITestCase.testDeleteHistory The following tests have been failing on iPad: HistoryUITestCase.testDisplayNoHistory HistoryUITestCase.testHistoryUpdateAfterBackNavigation HistoryUITestCase.testSearchHistory HistoryUITestCase.testHistoryEntriesStatusCell BUG=704403 TBR=jif Review-Url: https://codereview.chromium.org/2769973002 Cr-Commit-Position: refs/heads/master@{#459003} Committed: https://chromium.googlesource.com/chromium/src/+/a7c1e9614488466ff9600bfc413184aa5741479a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M ios/chrome/browser/ui/history/history_ui_egtest.mm View 5 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
baxley
Disabling these tests which have been failing for several hours. I didn't revert, since it's ...
3 years, 9 months ago (2017-03-23 04:20:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769973002/1
3 years, 9 months ago (2017-03-23 04:20:41 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 04:29:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7c1e9614488466ff9600bfc4131...

Powered by Google App Engine
This is Rietveld 408576698