[ios clean] Creates ToolsMenu Mediator and Consumer

[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced in a future
CL.



BUG=682880
Review-Url: https://codereview.chromium.org/2769963007
Cr-Commit-Position: refs/heads/master@{#460258}
Committed: https://chromium.googlesource.com/chromium/src/+/f8072f5360ed41e1e41265a1d528047aa4dcd3a0

[sczs, 2017-03-27 22:17:26]

Patchset #1 (id:1) has been deleted

[sczs, 2017-03-27 23:35:45]

Description was changed from

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

Creates a ToolsMenu Mediator and Consumer protocol.

BUG=682880
==========

to

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced on future
CL's.



BUG=682880
==========

[sczs, 2017-03-27 23:35:46]

sczs@chromium.org changed reviewers:
+ edchin@chromium.org, lpromero@chromium.org, marq@chromium.org,
rohitrao@chromium.org

[sczs, 2017-03-27 23:36:26]

Description was changed from

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced on future
CL's.



BUG=682880
==========

to

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced on future
CL's.



BUG=682880
==========

[sczs, 2017-03-27 23:36:42]

Patchset #1 (id:20001) has been deleted

[sczs, 2017-03-27 23:37:54]

Description was changed from

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced on future
CL's.



BUG=682880
==========

to

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced in a
future
CL's.



BUG=682880
==========

[sczs, 2017-03-27 23:40:49]

Description was changed from

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced in a
future
CL's.



BUG=682880
==========

to

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced in a
future
CL.



BUG=682880
==========

[sczs, 2017-03-27 23:41:04]

PTAL

[lpromero, 2017-03-28 11:45:43]

lg

[marq (ping after 24h), 2017-03-28 15:17:52]

lgtm

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/tools_consumer.h (right):

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/tools_consumer.h:14: // final and might change
depending on how we set the ToolsMenuVC model.
Even for a placeholder, don't use "we" in comments.

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/tools_coordinator.mm (right):

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/tools_coordinator.mm:40:
self.mediator.consumer = self.menuViewController;
We haven't sorted out how we're going to handle differing lifetimes of consumers
and mediators (with a delegate or a proxy or something else), but I think in the
meantime, where possible, we should just make consumers a required property of
mediators passed on construction. So in this case the mediator would be created
at the same time as the view controller, and have it passed into its init.

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/tools_mediator.h (right):

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/tools_mediator.h:14: // The consumer for this
object. This can change during the lifetime of this
I think this was boilerplate that I wrote for WebConsumer that in retrospect we
shouldn't have.

[sczs, 2017-03-28 21:37:25]

The CQ bit was checked by sczs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:37:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 22:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:17:10]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sczs, 2017-03-29 00:48:00]

The CQ bit was checked by sczs@chromium.org

[sczs, 2017-03-29 00:48:01]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2769963007/#ps60001
(title: "CL Feedback, ARC Guards and Comments")

[commit-bot: I haz the power, 2017-03-29 00:48:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:24:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490748480565750,
"parent_rev": "e589313cfc0a5f177668275af93feedb046f783f", "commit_rev":
"f8072f5360ed41e1e41265a1d528047aa4dcd3a0"}

[commit-bot: I haz the power, 2017-03-29 01:25:12]

Description was changed from

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced in a
future
CL.



BUG=682880
==========

to

==========
[ios clean] Creates ToolsMenu Mediator and Consumer

The CL primary purpose is to create the necessary Consumer, Mediator and
ToolsMenuItem files, and hook them together.

The consumer protocol method is not intended to be final and will remain as a
placeholder for now. The model is also hardcoded and will be replaced in a
future
CL.



BUG=682880

Review-Url: https://codereview.chromium.org/2769963007
Cr-Commit-Position: refs/heads/master@{#460258}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8072f5360ed41e1e41265a1d528...
==========

[commit-bot: I haz the power, 2017-03-29 01:25:13]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f8072f5360ed41e1e41265a1d528...

[sczs, 2017-03-29 14:52:49]

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/tools_consumer.h (right):

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/tools_consumer.h:14: // final and might change
depending on how we set the ToolsMenuVC model.
On 2017/03/28 15:17:52, marq wrote:
> Even for a placeholder, don't use "we" in comments.

Done.

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/tools_coordinator.mm (right):

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/tools_coordinator.mm:40:
self.mediator.consumer = self.menuViewController;
On 2017/03/28 15:17:52, marq wrote:
> We haven't sorted out how we're going to handle differing lifetimes of
consumers
> and mediators (with a delegate or a proxy or something else), but I think in
the
> meantime, where possible, we should just make consumers a required property of
> mediators passed on construction. So in this case the mediator would be
created
> at the same time as the view controller, and have it passed into its init.

Sounds like a good idea. Done.

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/tools_mediator.h (right):

https://codereview.chromium.org/2769963007/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/tools_mediator.h:14: // The consumer for this
object. This can change during the lifetime of this
On 2017/03/28 15:17:52, marq wrote:
> I think this was boilerplate that I wrote for WebConsumer that in retrospect
we
> shouldn't have. 

Acknowledged.