Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2769913002: Better detect color options for Samsung CUPS printers. (Closed)

Created:
3 years, 9 months ago by Lei Zhang
Modified:
3 years, 9 months ago
Reviewers:
skau, rbpotter
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Better detect color options for Samsung CUPS printers. BUG=702803 Review-Url: https://codereview.chromium.org/2769913002 Cr-Commit-Position: refs/heads/master@{#459181} Committed: https://chromium.googlesource.com/chromium/src/+/91d04b6f3dd86851c91fd82107ee1c6c1adce5e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -22 lines) Patch
M printing/backend/cups_helper.cc View 11 chunks +27 lines, -20 lines 0 comments Download
M printing/backend/cups_helper_unittest.cc View 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
More of the same.
3 years, 9 months ago (2017-03-23 02:40:19 UTC) #6
rbpotter
On 2017/03/23 02:40:19, Lei Zhang wrote: > More of the same. lgtm
3 years, 9 months ago (2017-03-23 19:27:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769913002/1
3 years, 9 months ago (2017-03-23 19:33:33 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 19:40:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91d04b6f3dd86851c91fd82107ee...

Powered by Google App Engine
This is Rietveld 408576698