Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2769843004: customtabs: Read the SharedPreferences early to avoid StrictMode violations. (Closed)

Created:
3 years, 9 months ago by Benoit L
Modified:
3 years, 8 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Read the SharedPreferences early to avoid StrictMode violations. The first access to SharedPreferences causes a StrictMode violation since it touches the disk. Read the preferences in a background thread as soon as possible to avoid this. BUG=704483 Review-Url: https://codereview.chromium.org/2769843004 Cr-Commit-Position: refs/heads/master@{#466716} Committed: https://chromium.googlesource.com/chromium/src/+/6687e9804bcef77c2a9b687d65b9ca65951b352a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Benoit L
Oops, forgot to send this for review. PTAL.
3 years, 8 months ago (2017-04-19 10:28:31 UTC) #6
Benoit L
On 2017/04/19 10:28:31, Benoit L wrote: > Oops, forgot to send this for review. > ...
3 years, 8 months ago (2017-04-24 13:05:29 UTC) #7
Yusuf
lgtm
3 years, 8 months ago (2017-04-24 18:36:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769843004/1
3 years, 8 months ago (2017-04-24 18:37:26 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 19:39:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6687e9804bcef77c2a9b687d65b9...

Powered by Google App Engine
This is Rietveld 408576698