Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2769813003: [remoting android] Fix WebView deprecation warnings (Closed)

Created:
3 years, 9 months ago by Lambros
Modified:
3 years, 9 months ago
Reviewers:
joedow
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Fix WebView deprecation warnings One of the WebViewClient interface methods is deprecated, but it must be kept around to work on older Android versions. This CL implements both older and newer methods, with appropriate annotations to suppress build warnings. BUG=704295 Review-Url: https://codereview.chromium.org/2769813003 Cr-Commit-Position: refs/heads/master@{#459134} Committed: https://chromium.googlesource.com/chromium/src/+/c378901b8de15db486c3cba91696504fc99e353c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/help/CreditsActivity.java View 2 chunks +17 lines, -3 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/help/HelpActivity.java View 4 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lambros
3 years, 9 months ago (2017-03-22 22:25:26 UTC) #2
joedow
lgtm
3 years, 9 months ago (2017-03-23 17:21:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769813003/1
3 years, 9 months ago (2017-03-23 17:39:41 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 17:52:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c378901b8de15db486c3cba91696...

Powered by Google App Engine
This is Rietveld 408576698