Centralize more querySelector logic behind QuerySelectorCache.

Centralize more querySelector logic behind QuerySelectorCache.

We make the types to the functions more clear, move the empty selector
check inside, and handle the NthIndexCache automatically instead of
expecting the callers to do the setup.

This also unifies the exception messages for matches(), closest(),
querySelector(), and querySelectorAll() when an empty string is passed.

BUG=703900
Review-Url: https://codereview.chromium.org/2769783002
Cr-Commit-Position: refs/heads/master@{#458942}
Committed: https://chromium.googlesource.com/chromium/src/+/146a91c44120872cb59aba6078b7cb40e4e8f4f6

[esprehn, 2017-03-22 19:19:09]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 19:19:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2017-03-22 19:20:00]

Description was changed from

==========
Centralize more querySelector logic behind QuerySelectorCache.

We make the types to the functions more clear, move the empty selector
check inside, and handle the NthIndexCache automatically instead of
expecting the DOM callers to do the setup.

BUG=703900
==========

to

==========
Centralize more querySelector logic behind QuerySelectorCache.

We make the types to the functions more clear, move the empty selector
check inside, and handle the NthIndexCache automatically instead of
expecting the callers to do the setup.

This also unifies the exception messages for matches(), closest(),
querySelector(), and querySelectorAll() when an empty string is passed.

BUG=703900
==========

[esprehn, 2017-03-22 20:21:38]

esprehn@chromium.org changed reviewers:
+ rune@opera.com, sashab@chromium.org

[commit-bot: I haz the power, 2017-03-22 20:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 20:51:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2017-03-22 22:22:16]

lgtm

[esprehn, 2017-03-22 23:47:38]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:48:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:09:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490226458509910, "parent_rev":
"4f03d873326c61514cea9f4b4f293c43a7327b76", "commit_rev":
"146a91c44120872cb59aba6078b7cb40e4e8f4f6"}

[commit-bot: I haz the power, 2017-03-23 00:10:31]

Description was changed from

==========
Centralize more querySelector logic behind QuerySelectorCache.

We make the types to the functions more clear, move the empty selector
check inside, and handle the NthIndexCache automatically instead of
expecting the callers to do the setup.

This also unifies the exception messages for matches(), closest(),
querySelector(), and querySelectorAll() when an empty string is passed.

BUG=703900
==========

to

==========
Centralize more querySelector logic behind QuerySelectorCache.

We make the types to the functions more clear, move the empty selector
check inside, and handle the NthIndexCache automatically instead of
expecting the callers to do the setup.

This also unifies the exception messages for matches(), closest(),
querySelector(), and querySelectorAll() when an empty string is passed.

BUG=703900

Review-Url: https://codereview.chromium.org/2769783002
Cr-Commit-Position: refs/heads/master@{#458942}
Committed:
https://chromium.googlesource.com/chromium/src/+/146a91c44120872cb59aba6078b7...
==========

[commit-bot: I haz the power, 2017-03-23 00:10:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/146a91c44120872cb59aba6078b7...