X11: Fix task manager able to resize to 1x1px

X11: Fix task manager able to resize to 1x1px

The call to XSetWMNormalHints in DWTHX11::MapWindow was clobbering the
WM_NORMAL_HINTS property, which includes hints about window
positioning and min/max size.  I believe the intention was to only
change the PPosition hint, because it does "size_hints.flags =
PPosition".  This unsets the other hints as well.  The correct
behavior is to do XGetWMNormalHints before XSetWMNormalHints.

BUG=704772
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2769773004
Cr-Commit-Position: refs/heads/master@{#459517}
Committed: https://chromium.googlesource.com/chromium/src/+/58d4af36b33d601214867661b8d9e1e6c1d9fb56

[Tom (Use chromium acct), 2017-03-24 01:43:22]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 01:43:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 02:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 02:29:02]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-03-24 17:15:56]

can other processes modify our hints? if so, our caching won't reflect them.

[Tom (Use chromium acct), 2017-03-24 18:24:44]

On 2017/03/24 17:15:56, Elliot Glaysher wrote:
> can other processes modify our hints? if so, our caching won't reflect them.

I guess since x11 is anarchy, that is possible.  updated the latest PS

[Elliot Glaysher, 2017-03-24 18:25:17]

lgtm

[Tom (Use chromium acct), 2017-03-24 18:26:06]

Description was changed from

==========
X11: Fix task manager able to resize to 1x1px

The call to XSetWMNormalHints in DWTHX11::MapWindow was clobbering the
WM_NORMAL_HINTS property, which includes hints about window
positioning and min/max size.  I believe the intention was to only
change the PPosition hint, because it does "size_hints.flags =
PPosition".  This unsets the other hints as well.  The correct
behavior is to do XGetWMNormalHints before XSetWMNormalHints.

In addition, this CL caches WM_NORMAL_HINTS so that the round-trip
mentioned above due to the read-modify-write is not needed.

BUG=704772
R=erg@chromium.org
==========

to

==========
X11: Fix task manager able to resize to 1x1px

The call to XSetWMNormalHints in DWTHX11::MapWindow was clobbering the
WM_NORMAL_HINTS property, which includes hints about window
positioning and min/max size.  I believe the intention was to only
change the PPosition hint, because it does "size_hints.flags =
PPosition".  This unsets the other hints as well.  The correct
behavior is to do XGetWMNormalHints before XSetWMNormalHints.

BUG=704772
R=erg@chromium.org
==========

[Tom (Use chromium acct), 2017-03-24 18:28:51]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-03-24 18:29:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 19:24:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490380131736550,
"parent_rev": "c01583e3b61d79c7b54b2ffd05fe946d940fd792", "commit_rev":
"58d4af36b33d601214867661b8d9e1e6c1d9fb56"}

[commit-bot: I haz the power, 2017-03-24 19:25:38]

Description was changed from

==========
X11: Fix task manager able to resize to 1x1px

The call to XSetWMNormalHints in DWTHX11::MapWindow was clobbering the
WM_NORMAL_HINTS property, which includes hints about window
positioning and min/max size.  I believe the intention was to only
change the PPosition hint, because it does "size_hints.flags =
PPosition".  This unsets the other hints as well.  The correct
behavior is to do XGetWMNormalHints before XSetWMNormalHints.

BUG=704772
R=erg@chromium.org
==========

to

==========
X11: Fix task manager able to resize to 1x1px

The call to XSetWMNormalHints in DWTHX11::MapWindow was clobbering the
WM_NORMAL_HINTS property, which includes hints about window
positioning and min/max size.  I believe the intention was to only
change the PPosition hint, because it does "size_hints.flags =
PPosition".  This unsets the other hints as well.  The correct
behavior is to do XGetWMNormalHints before XSetWMNormalHints.

BUG=704772
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2769773004
Cr-Commit-Position: refs/heads/master@{#459517}
Committed:
https://chromium.googlesource.com/chromium/src/+/58d4af36b33d601214867661b8d9...
==========

[commit-bot: I haz the power, 2017-03-24 19:25:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/58d4af36b33d601214867661b8d9...