Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2769773003: [wrapper-tracing] Emite write barrier upon associating a wrapper (Closed)

Created:
3 years, 9 months ago by Michael Lippautz
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Emite write barrier upon associating a wrapper Whenever we assign a reference that should be traced into V8 we need to emit a write barrier. We automatically emit write barriers for TraceWrapperv8Reference. However, we still use a regular (weak) Persistent in ScriptWrappable, so we need to emit the barrier there manually. A follow up should convert the reference in ScriptWrappable to TraceWrapperv8Reference. BUG=chromium:702490 Review-Url: https://codereview.chromium.org/2759243002 Cr-Commit-Position: refs/heads/master@{#458357} (cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b) Review-Url: https://codereview.chromium.org/2769773003 . Cr-Commit-Position: refs/branch-heads/3029@{#381} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5fe2bd0c1d820fed608f60f1e6dcda168e013bf7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 3 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MutationCallback.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Michael Lippautz
3 years, 9 months ago (2017-03-23 12:28:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5fe2bd0c1d820fed608f60f1e6dcda168e013bf7.

Powered by Google App Engine
This is Rietveld 408576698