Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2769763002:
Merge the patch back into M58 (Closed)
DescriptionRemove logic about recording style related main thread scroll reasons
The current recording incorrectly propagates the style related main thread scrolling reasons
of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any
scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in
smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking
release of M57 stable, it's better to remove the recording logic for now and work
on a correct one in a following patch.
BUG=701355
TBR=pdr@chromium.org
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2766893002
Cr-Commit-Position: refs/heads/master@{#458596}
(cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46)
Review-Url: https://codereview.chromium.org/2769763002
Cr-Commit-Position: refs/branch-heads/3029@{#366}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/493ca6a37c65b8c751fc5e50a00b0126b10758a8
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) ========== to ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) ==========
yigu@chromium.org changed reviewers: + flackr@chromium.org
Hi Rob, PTAL at this merge patch. Thanks!
lgtm
Description was changed from ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) ========== to ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 TBR=pdr@chromium.org Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) ==========
yigu@chromium.org changed reviewers: + pdr@chromium.org
The CQ bit was checked by yigu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 TBR=pdr@chromium.org Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) ========== to ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 TBR=pdr@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) ==========
The CQ bit was checked by yigu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490208373894900, "parent_rev":
"732886833918962609cf5e6d25398c8e02b06e1d", "commit_rev":
"493ca6a37c65b8c751fc5e50a00b0126b10758a8"}
Message was sent while issue was closed.
Description was changed from ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 TBR=pdr@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) ========== to ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 TBR=pdr@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) Review-Url: https://codereview.chromium.org/2769763002 Cr-Commit-Position: refs/branch-heads/3029@{#366} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/493ca6a37c65b8c751fc5e50a00b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/493ca6a37c65b8c751fc5e50a00b...
Message was sent while issue was closed.
Description was changed from ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 TBR=pdr@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) Review-Url: https://codereview.chromium.org/2769763002 Cr-Commit-Position: refs/branch-heads/3029@{#366} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/493ca6a37c65b8c751fc5e50a00b... ========== to ========== Remove logic about recording style related main thread scroll reasons The current recording incorrectly propagates the style related main thread scrolling reasons of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking release of M57 stable, it's better to remove the recording logic for now and work on a correct one in a following patch. BUG=701355 TBR=pdr@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2766893002 Cr-Commit-Position: refs/heads/master@{#458596} (cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46) Review-Url: https://codereview.chromium.org/2769763002 Cr-Commit-Position: refs/branch-heads/3029@{#366} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/493ca6a37c65b8c751fc5e50a00b... ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
