Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2769743005: Fix High Contrast extension (Closed)

Created:
3 years, 9 months ago by dmazzoni
Modified:
3 years, 8 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix High Contrast extension Chrome 45+ doesn't let you set a filter on the HTML element anymore, so we have to create a separate element with low z-index and copy the background. In addition, the filter seems to need to be fixed-positioned or Chrome won't properly update it. BUG=534971, 591476 NOTRY=true Review-Url: https://codereview.chromium.org/2769743005 Cr-Commit-Position: refs/heads/master@{#460158} Committed: https://chromium.googlesource.com/chromium/src/+/adaaccd59252c8fb9af08fcf65e8b78f25f053b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -113 lines) Patch
D ui/accessibility/extensions/highcontrast/highcontrast.css View 1 chunk +0 lines, -81 lines 0 comments Download
M ui/accessibility/extensions/highcontrast/highcontrast.js View 6 chunks +84 lines, -28 lines 0 comments Download
M ui/accessibility/extensions/highcontrast/manifest.json View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
dmazzoni
The previous patchset was incomplete. This change has all of the hacks ("fixes") to the ...
3 years, 9 months ago (2017-03-24 21:27:03 UTC) #2
Peter Wen
lgtm, filter fixes work for colorenhancer
3 years, 9 months ago (2017-03-27 18:03:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769743005/1
3 years, 8 months ago (2017-03-28 17:31:14 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:37:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/adaaccd59252c8fb9af08fcf65e8...

Powered by Google App Engine
This is Rietveld 408576698