[wasm] Allow --turbo-stats to collect wasm compilation info.

[wasm] Allow --turbo-stats to collect wasm compilation info.

Enable compilation stats for Wasm code.
As parallel compilation can interfere with these measurements,
also force single threaded compilation when collecting stats.

BUG=None
TEST=None
LOG=N
R=mtrofin@chromium.org

Review-Url: https://codereview.chromium.org/2769743002
Cr-Commit-Position: refs/heads/master@{#44046}
Committed: https://chromium.googlesource.com/v8/v8/+/8d708c6593ec83a7adf35491db98fb07023bb819

[bradnelson, 2017-03-22 18:09:22]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 18:09:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2017-03-22 18:09:37]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[Mircea Trofin, 2017-03-22 18:12:22]

lgtm, 1 nit/question

https://codereview.chromium.org/2769743002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/2769743002/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:667: std::unique_ptr<PipelineStatistics>
pipeline_statistics_;
can we move this guy up in CompilationJob?

[commit-bot: I haz the power, 2017-03-22 18:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 18:40:14]

Dry run: This issue passed the CQ dry run.

[bradn, 2017-03-22 18:46:45]

https://codereview.chromium.org/2769743002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/2769743002/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:667: std::unique_ptr<PipelineStatistics>
pipeline_statistics_;
On 2017/03/22 18:12:21, Mircea Trofin wrote:
> can we move this guy up in CompilationJob?

Ugh.
If you mean CompilationJob, that's tricky as it's meant to be opaque.
That seems like it would muddy up things elsewhere.
An alternative would be a common base for PipelineCompilationJob /
WasmCompilationJob that adds in pipeline_stat + zone_stats?

Do you mean move it into PipelineData?
That might be cleaner, but wow that guy is a rather odd how it seems to only
hold references, yick.

[bradn, 2017-03-22 19:48:28]

Offline decided this will be hard.
Landing this way.

[bradn, 2017-03-22 19:48:33]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2017-03-22 19:48:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 19:49:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490212113249010, "parent_rev":
"2747ab31ef64c7d2d0e5d726962bd9a382b0b0e8", "commit_rev":
"8d708c6593ec83a7adf35491db98fb07023bb819"}

[commit-bot: I haz the power, 2017-03-22 19:50:03]

Description was changed from

==========
[wasm] Allow --turbo-stats to collect wasm compilation info.

Enable compilation stats for Wasm code.
As parallel compilation can interfere with these measurements,
also force single threaded compilation when collecting stats.

BUG=None
TEST=None
LOG=N
R=mtrofin@chromium.org
==========

to

==========
[wasm] Allow --turbo-stats to collect wasm compilation info.

Enable compilation stats for Wasm code.
As parallel compilation can interfere with these measurements,
also force single threaded compilation when collecting stats.

BUG=None
TEST=None
LOG=N
R=mtrofin@chromium.org

Review-Url: https://codereview.chromium.org/2769743002
Cr-Commit-Position: refs/heads/master@{#44046}
Committed:
https://chromium.googlesource.com/v8/v8/+/8d708c6593ec83a7adf35491db98fb07023...
==========

[commit-bot: I haz the power, 2017-03-22 19:50:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8d708c6593ec83a7adf35491db98fb07023...