Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2769703007: Revert of Enable noexcept on Windows, use for a few move constructors. (Closed)

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
brettw, brucedawson, lfg
CC:
chromium-reviews, Dirk Pranke, agrieve+watch_chromium.org, tfarina, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable noexcept on Windows, use for a few move constructors. (patchset #3 id:40001 of https://codereview.chromium.org/2771643002/ ) Reason for revert: Seems to have broken Windows build with args.gn as: > is_debug = true > is_component_build = true > enable_nacl = false > is_chrome_branded = true > symbol_level = 2 > target_cpu = "x86" > is_win_fastlink = true > is_clang = false > win_console_app = true > win_linker_timing = true Original issue's description: > Enable noexcept on Windows, use for a few move constructors. > > MSVC complains if you use noexcept with no exception handling mode specified (as we do). > This code disables the warning. noexcept on move constructors allows better optimizations > in some cases. > http://en.cppreference.com/w/cpp/language/noexcept_spec > > Updates a few common classes' move constructors to use this. > > Review-Url: https://codereview.chromium.org/2771643002 > Cr-Commit-Position: refs/heads/master@{#458956} > Committed: https://chromium.googlesource.com/chromium/src/+/76aac97386e2788241161420c5e7e0bfee16f88c TBR=brucedawson@chromium.org,lfg@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2769703007 Cr-Commit-Position: refs/heads/master@{#459101} Committed: https://chromium.googlesource.com/chromium/src/+/12c27f45b2cd8fea6c833a47d5270da42d791740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M base/android/jni_weak_ref.h View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_weak_ref.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/values.h View 1 chunk +1 line, -1 line 0 comments Download
M base/values.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 3 chunks +15 lines, -13 lines 0 comments Download
M tools/gn/value.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/value.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/gurl.h View 1 chunk +1 line, -1 line 0 comments Download
M url/gurl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
scottmg
Created Revert of Enable noexcept on Windows, use for a few move constructors.
3 years, 9 months ago (2017-03-23 15:57:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769703007/1
3 years, 9 months ago (2017-03-23 15:57:48 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 16:04:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/12c27f45b2cd8fea6c833a47d527...

Powered by Google App Engine
This is Rietveld 408576698