DescriptionRevert of Enable noexcept on Windows, use for a few move constructors. (patchset #3 id:40001 of https://codereview.chromium.org/2771643002/ )
Reason for revert:
Seems to have broken Windows build with args.gn as:
> is_debug = true
> is_component_build = true
> enable_nacl = false
> is_chrome_branded = true
> symbol_level = 2
> target_cpu = "x86"
> is_win_fastlink = true
> is_clang = false
> win_console_app = true
> win_linker_timing = true
Original issue's description:
> Enable noexcept on Windows, use for a few move constructors.
>
> MSVC complains if you use noexcept with no exception handling mode specified (as we do).
> This code disables the warning. noexcept on move constructors allows better optimizations
> in some cases.
> http://en.cppreference.com/w/cpp/language/noexcept_spec
>
> Updates a few common classes' move constructors to use this.
>
> Review-Url: https://codereview.chromium.org/2771643002
> Cr-Commit-Position: refs/heads/master@{#458956}
> Committed: https://chromium.googlesource.com/chromium/src/+/76aac97386e2788241161420c5e7e0bfee16f88c
TBR=brucedawson@chromium.org,lfg@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2769703007
Cr-Commit-Position: refs/heads/master@{#459101}
Committed: https://chromium.googlesource.com/chromium/src/+/12c27f45b2cd8fea6c833a47d5270da42d791740
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|