Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 2769703003: Search the entire subtree when looking for the end of an inline continuation chain. (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Search the entire subtree when looking for the end of an inline continuation chain. Inlines may be nested, so we may not find the last inline in the chain as a direct child of the anonymous blocks. We need to search the entire subtree. Don't do this with anonymous blocks that wrap block children (the block-level DOM children of the inline-level objects), though. We're not going to find anything interesting there. This fix is speculative; the original bug report didn't come with a test case. BUG=662767 Review-Url: https://codereview.chromium.org/2738503004 Cr-Commit-Position: refs/heads/master@{#455420} (cherry picked from commit e72c8c06b956706b54648589f807086d17340831) Review-Url: https://codereview.chromium.org/2769703003 . Cr-Commit-Position: refs/branch-heads/2987@{#862} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/82a69bd443feb20d88e1adfbf77c5c657892484d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-in-anchor-and-img-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-22 18:35:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
82a69bd443feb20d88e1adfbf77c5c657892484d.

Powered by Google App Engine
This is Rietveld 408576698