Run dartfmt on generated file.

Run dartfmt on generated file.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/9d439605a8bd32aa58efba6b765166c6cbee6fed

[ahe, 2017-03-22 12:58:34]

ahe@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-03-22 13:04:18]

LGTM

[ahe, 2017-03-23 12:09:22]

Description was changed from

==========
Run dartfmt on generated file.
==========

to

==========
Run dartfmt on generated file.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9d439605a8bd32aa58efba6b765166c6cbee6fed
==========

[ahe, 2017-03-23 12:09:24]

Committed patchset #1 (id:1) manually as
9d439605a8bd32aa58efba6b765166c6cbee6fed (presubmit successful).

[Siggi Cherem (dart-lang), 2017-07-12 20:06:50]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-07-12 20:06:51]

https://codereview.chromium.org/2769663002/diff/1/pkg/front_end/tool/_fasta/g...
File pkg/front_end/tool/_fasta/generate_messages.dart (right):

https://codereview.chromium.org/2769663002/diff/1/pkg/front_end/tool/_fasta/g...
pkg/front_end/tool/_fasta/generate_messages.dart:13: import
'package:dart_style/dart_style.dart' show DartFormatter;
note: this introduced a circular dependency on fasta_codes_generated.dart
(package:dart_style imports  package:analyzer which in turn imports
package:front_end including the generated file.)

As a result, if the file is missing or broken this script fails to run. I run
into this because of a merge conflict and wanted to regenerate the file without
bothering to revert it to a valid Dart file.

I suggest we run the formatter as a separate process instead.

[ahe, 2017-07-13 00:26:54]

https://codereview.chromium.org/2769663002/diff/1/pkg/front_end/tool/_fasta/g...
File pkg/front_end/tool/_fasta/generate_messages.dart (right):

https://codereview.chromium.org/2769663002/diff/1/pkg/front_end/tool/_fasta/g...
pkg/front_end/tool/_fasta/generate_messages.dart:13: import
'package:dart_style/dart_style.dart' show DartFormatter;
On 2017/07/12 20:06:51, Siggi Cherem (dart-lang) wrote:
> note: this introduced a circular dependency on fasta_codes_generated.dart
> (package:dart_style imports  package:analyzer which in turn imports
> package:front_end including the generated file.)
> 
> As a result, if the file is missing or broken this script fails to run. I run
> into this because of a merge conflict and wanted to regenerate the file
without
> bothering to revert it to a valid Dart file.
> 
> I suggest we run the formatter as a separate process instead.

We could do that, but then we have to use the slightly outdated version that's
stored somewhere in tools/. That's also a source of confusion.

What I've been doing is this:

git checkout current_branch_name --
pkg/front_end/lib/src/fasta/fasta_codes_generated.dart

Is that an acceptable workaround for you?

[Siggi Cherem (dart-lang), 2017-07-13 19:16:51]

On 2017/07/13 00:26:54, ahe wrote:
>
https://codereview.chromium.org/2769663002/diff/1/pkg/front_end/tool/_fasta/g...
> File pkg/front_end/tool/_fasta/generate_messages.dart (right):
> 
>
https://codereview.chromium.org/2769663002/diff/1/pkg/front_end/tool/_fasta/g...
> pkg/front_end/tool/_fasta/generate_messages.dart:13: import
> 'package:dart_style/dart_style.dart' show DartFormatter;
> On 2017/07/12 20:06:51, Siggi Cherem (dart-lang) wrote:
> > note: this introduced a circular dependency on fasta_codes_generated.dart
> > (package:dart_style imports  package:analyzer which in turn imports
> > package:front_end including the generated file.)
> > 
> > As a result, if the file is missing or broken this script fails to run. I
run
> > into this because of a merge conflict and wanted to regenerate the file
> without
> > bothering to revert it to a valid Dart file.
> > 
> > I suggest we run the formatter as a separate process instead.
> 
> We could do that, but then we have to use the slightly outdated version that's
> stored somewhere in tools/. That's also a source of confusion.

True, note however that the PRESUBMIT script we use for all CLs also uses the
one under `tools/sdks/linux/dart-sdk/bin/dartfmt`. So using this outdated
version would make things more consistent overall.

> 
> What I've been doing is this:
> 
> git checkout current_branch_name --
> pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
> 
> Is that an acceptable workaround for you?

That's OK for me, but might come at a surprise if someone outside the team is
editing messages and runs into this.