Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2765253002: Report error on only-try block. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -172 lines) Patch
M pkg/front_end/lib/src/fasta/parser/error_kind.dart View 3 chunks +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/problems.dart View 27 chunks +106 lines, -168 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/tool/_fasta/generate_messages.dart View 2 chunks +4 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-22 12:48:18 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-22 13:04:01 UTC) #3
ahe
3 years, 9 months ago (2017-03-23 12:02:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0afdf6b44a81c1207ffe0a83f7cc44a50d840240 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698