Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2769593002: MD Settings/Downloads: show file chooser after CHANGE button ripple completes (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings/Downloads: show file chooser after CHANGE button ripple completes R=tsergeant@chromium.org BUG=703911 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2769593002 Cr-Commit-Position: refs/heads/master@{#458889} Committed: https://chromium.googlesource.com/chromium/src/+/19ee831cfd08be82b953ff25a1c62db1f72fc417

Patch Set 1 #

Patch Set 2 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M chrome/browser/resources/settings/downloads_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/downloads_page_test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js View 1 chunk +21 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Dan Beam
3 years, 9 months ago (2017-03-22 03:02:38 UTC) #4
tsergeant
lgtm
3 years, 9 months ago (2017-03-22 03:07:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769593002/1
3 years, 9 months ago (2017-03-22 03:11:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/411917)
3 years, 9 months ago (2017-03-22 03:31:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769593002/20001
3 years, 9 months ago (2017-03-22 20:58:13 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 22:08:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19ee831cfd08be82b953ff25a1c6...

Powered by Google App Engine
This is Rietveld 408576698