cros: Clean up TrayBluetoothHelper todos

cros: Clean up TrayBluetoothHelper todos

* Make GetAvailableBluetoothDevices() directly return the list
* Add comments

BUG=660043
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2769553002
Cr-Commit-Position: refs/heads/master@{#458738}
Committed: https://chromium.googlesource.com/chromium/src/+/ca8c398302a2c20ec014439d7d74ca1eeb6c9e5a

[James Cook, 2017-03-21 23:31:59]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 23:32:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-03-21 23:35:34]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-03-21 23:35:35]

msw, please take a look.

https://codereview.chromium.org/2769553002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/bluetooth/tray_bluetooth_helper.h (right):

https://codereview.chromium.org/2769553002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/bluetooth/tray_bluetooth_helper.h:26: struct
ASH_EXPORT BluetoothDeviceInfo {
It's possible this struct could be eliminated by making TrayBluetooth store
lists of device addresses instead of lists of this struct. However, the UI would
have to look up the device info from the adapter every time it does something.
I'm concerned that there may be cases where the UI transiently needs to display
a device that just disconnected from the adapter. Also, there are no tests of
TrayBluetooth. So I don't think this is worth "fixing".

[msw, 2017-03-21 23:48:42]

lgtm

https://codereview.chromium.org/2769553002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/bluetooth/tray_bluetooth_helper.h (right):

https://codereview.chromium.org/2769553002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/bluetooth/tray_bluetooth_helper.h:26: struct
ASH_EXPORT BluetoothDeviceInfo {
On 2017/03/21 23:35:35, James Cook wrote:
> It's possible this struct could be eliminated by making TrayBluetooth store
> lists of device addresses instead of lists of this struct. However, the UI
would
> have to look up the device info from the adapter every time it does something.
> I'm concerned that there may be cases where the UI transiently needs to
display
> a device that just disconnected from the adapter. Also, there are no tests of
> TrayBluetooth. So I don't think this is worth "fixing".

Acknowledged.

[James Cook, 2017-03-21 23:54:27]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-03-21 23:54:33]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:54:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 01:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:35:03]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[James Cook, 2017-03-22 13:56:43]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-03-22 13:56:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 13:59:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490191003566600,
"parent_rev": "d38b95f21eebdcc6a01eaee260e94ffa0cc746a0", "commit_rev":
"ca8c398302a2c20ec014439d7d74ca1eeb6c9e5a"}

[commit-bot: I haz the power, 2017-03-22 14:00:32]

Description was changed from

==========
cros: Clean up TrayBluetoothHelper todos

* Make GetAvailableBluetoothDevices() directly return the list
* Add comments

BUG=660043
TEST=ash_unittests
==========

to

==========
cros: Clean up TrayBluetoothHelper todos

* Make GetAvailableBluetoothDevices() directly return the list
* Add comments

BUG=660043
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2769553002
Cr-Commit-Position: refs/heads/master@{#458738}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca8c398302a2c20ec014439d7d74...
==========

[commit-bot: I haz the power, 2017-03-22 14:00:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ca8c398302a2c20ec014439d7d74...