Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 2769433002: Revert of Add use count for click retargeting due to capture (Closed)

Created:
3 years, 9 months ago by Navid Zolghadr
Modified:
3 years, 9 months ago
Reviewers:
bokan, dtapuska, mustaq
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add use count for click retargeting due to capture Reason for revert: Reverting all the changes related to the click target in capturing as they are splitted across multiple commits. This reverts commit 18a3165ddb7326845a6028b1e3f93f7d347bde95. Original issue's description Since pointer capture changes the target of the following events for that pointer it potentially changes the target of the click. Considering the changed target for calculating the click target may cause some websites to break. So this CL adds a usecount for that case. Note this is an upper bound on the breakage as lots of pages may not have any listener for these click events or just not break due to this retargetting. BUG=699933 TBR=dtapuska@chromium.org,mustaq@chromium.org,bokan@chromium.org Review-Url: https://codereview.chromium.org/2769433002 Cr-Commit-Position: refs/heads/master@{#458550} Committed: https://chromium.googlesource.com/chromium/src/+/3d84b135e186d7d22d9597aa752ddc8f345be102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M third_party/WebKit/Source/core/input/MouseEventManager.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769433002/1
3 years, 9 months ago (2017-03-21 19:46:30 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 21:21:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d84b135e186d7d22d9597aa752d...

Powered by Google App Engine
This is Rietveld 408576698