Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2769413002: Revert of Use stricter checking in UrlOverridingTest (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
Reviewers:
Maria, wychen
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use stricter checking in UrlOverridingTest (patchset #3 id:40001 of https://codereview.chromium.org/2763843002/ ) Reason for revert: Breaking tablet testers: [FAIL] org.chromium.chrome.browser.externalnav.UrlOverridingTest#testOpenWindowFromUserGesture: junit.framework.AssertionFailedError at org.chromium.chrome.browser.externalnav.UrlOverridingTest.loadUrlAndWaitForIntentUrl(UrlOverridingTest.java:174) at org.chromium.chrome.browser.externalnav.UrlOverridingTest.testOpenWindowFromUserGesture(UrlOverridingTest.java:332) at java.lang.reflect.Method.invokeNative(Native Method) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:752) at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) See bug for builder links. Original issue's description: > Use stricter checking in UrlOverridingTest > > Check the callback counts in all the test cases, and wait for the > fallback navigation to avoid early abortion. > > The failures with PlzNavigate are not fixed yet. > > BUG=699388 > > Review-Url: https://codereview.chromium.org/2763843002 > Cr-Commit-Position: refs/heads/master@{#459325} > Committed: https://chromium.googlesource.com/chromium/src/+/ffb0ffaccfcded76b0165c24c6ba0c8c4712089c TBR=mariakhomenko@chromium.org,wychen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699388 Review-Url: https://codereview.chromium.org/2769413002 Cr-Commit-Position: refs/heads/master@{#459416} Committed: https://chromium.googlesource.com/chromium/src/+/0f7b1afa9784fa186cc18dae4bb43c096dc6616b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java View 5 chunks +35 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dgn
Created Revert of Use stricter checking in UrlOverridingTest
3 years, 9 months ago (2017-03-24 14:21:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769413002/1
3 years, 9 months ago (2017-03-24 14:21:40 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 14:23:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f7b1afa9784fa186cc18dae4bb4...

Powered by Google App Engine
This is Rietveld 408576698