Chromium Code Reviews
DescriptionRevert of Use stricter checking in UrlOverridingTest (patchset #3 id:40001 of https://codereview.chromium.org/2763843002/ )
Reason for revert:
Breaking tablet testers:
[FAIL] org.chromium.chrome.browser.externalnav.UrlOverridingTest#testOpenWindowFromUserGesture:
junit.framework.AssertionFailedError
at org.chromium.chrome.browser.externalnav.UrlOverridingTest.loadUrlAndWaitForIntentUrl(UrlOverridingTest.java:174)
at org.chromium.chrome.browser.externalnav.UrlOverridingTest.testOpenWindowFromUserGesture(UrlOverridingTest.java:332)
at java.lang.reflect.Method.invokeNative(Native Method)
at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:752)
at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
See bug for builder links.
Original issue's description:
> Use stricter checking in UrlOverridingTest
>
> Check the callback counts in all the test cases, and wait for the
> fallback navigation to avoid early abortion.
>
> The failures with PlzNavigate are not fixed yet.
>
> BUG=699388
>
> Review-Url: https://codereview.chromium.org/2763843002
> Cr-Commit-Position: refs/heads/master@{#459325}
> Committed: https://chromium.googlesource.com/chromium/src/+/ffb0ffaccfcded76b0165c24c6ba0c8c4712089c
TBR=mariakhomenko@chromium.org,wychen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699388
Review-Url: https://codereview.chromium.org/2769413002
Cr-Commit-Position: refs/heads/master@{#459416}
Committed: https://chromium.googlesource.com/chromium/src/+/0f7b1afa9784fa186cc18dae4bb43c096dc6616b
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||