Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm

Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.
Patch Set: Addressing Review Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm b/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm
index 4aa0fae35581061d1a902563e2b4c322ae58bce0..6b667d6de0002f9d98704d79898a9bdfa7b63d7f 100644
--- a/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm
@@ -36,4 +36,10 @@ void ShowImportLockDialog(gfx::NativeWindow parent,
base::RecordAction(UserMetricsAction("ImportLockDialogCocoa_Shown"));
}
+void HideImportLockDialog() {
+ // This code path is not needed for Mac, as the user must explicitly close
+ // the sheet before any situation can arise in which we'd need to close it
+ // programmatically. See https://crbug.com/672428 for more details.
msw 2017/04/06 00:12:27 Views should probably instead use a tab or browser
+}
+
} // namespace importer

Powered by Google App Engine
This is Rietveld 408576698