Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm

Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.
Patch Set: Addressing Review Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/mac/scoped_nsobject.h" 9 #include "base/mac/scoped_nsobject.h"
10 #include "base/metrics/user_metrics.h" 10 #include "base/metrics/user_metrics.h"
(...skipping 18 matching lines...) Expand all
29 IDS_IMPORTER_LOCK_TEXT)]; 29 IDS_IMPORTER_LOCK_TEXT)];
30 [lock_alert setMessageText:l10n_util::GetNSStringWithFixup( 30 [lock_alert setMessageText:l10n_util::GetNSStringWithFixup(
31 IDS_IMPORTER_LOCK_TITLE)]; 31 IDS_IMPORTER_LOCK_TITLE)];
32 32
33 base::ThreadTaskRunnerHandle::Get()->PostTask( 33 base::ThreadTaskRunnerHandle::Get()->PostTask(
34 FROM_HERE, 34 FROM_HERE,
35 base::Bind(callback, [lock_alert runModal] == NSAlertFirstButtonReturn)); 35 base::Bind(callback, [lock_alert runModal] == NSAlertFirstButtonReturn));
36 base::RecordAction(UserMetricsAction("ImportLockDialogCocoa_Shown")); 36 base::RecordAction(UserMetricsAction("ImportLockDialogCocoa_Shown"));
37 } 37 }
38 38
39 void HideImportLockDialog() {
40 // This code path is not needed for Mac, as the user must explicitly close
41 // the sheet before any situation can arise in which we'd need to close it
42 // programmatically. See https://crbug.com/672428 for more details.
msw 2017/04/06 00:12:27 Views should probably instead use a tab or browser
43 }
44
39 } // namespace importer 45 } // namespace importer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698