chrome/browser/resources/settings/people_page/import_data_browser_proxy.js - Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/import_data_browser_proxy.js

Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.

Patch Set: Addressing Review Comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/importer/importer_lock_dialog.h ('k') | chrome/browser/resources/settings/people_page/import_data_dialog.html » ('j') | chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/import_data_browser_proxy.js

diff --git a/chrome/browser/resources/settings/people_page/import_data_browser_proxy.js b/chrome/browser/resources/settings/people_page/import_data_browser_proxy.js

index 24c108ec339dca52a30964ea449631c0850590a3..6cda2c8f0a5c13604fabb2448562cebee8c0664d 100644

--- a/chrome/browser/resources/settings/people_page/import_data_browser_proxy.js

+++ b/chrome/browser/resources/settings/people_page/import_data_browser_proxy.js

@@ -56,6 +56,11 @@ cr.define('settings', function() {

* Prompts the user to choose a bookmarks file to import bookmarks from.

importFromBookmarksFile: function() {},

+ /**

+ * Close the import lock dialog if it is opened.

+ */

+ closeImportLockDialog: function() {},

};

/**

@@ -82,6 +87,11 @@ cr.define('settings', function() {

importFromBookmarksFile: function() {

chrome.send('importFromBookmarksFile');

+ /** @override */

+ closeImportLockDialog: function() {

+ chrome.send('closeImportLockDialog');

+ },

};

return {