Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2769353003:
Return BSPatch value (previously, was ignored). (Closed)
DescriptionReturn BSPatch value (previously, was ignored).
BUG=705036
Review-Url: https://codereview.chromium.org/2769353003
Cr-Commit-Position: refs/heads/master@{#461326}
Committed: https://chromium.googlesource.com/chromium/src/+/761ab5e1b8a8e5d24200753b340250416c9b6a61
Patch Set 1 #
Total comments: 1
Patch Set 2 : Through #11 #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by waffles@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
waffles@chromium.org changed reviewers: + sorin@chromium.org, wfh@chromium.org
lgtm Thank you!
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Thanks for the fast reviews! Unfortunately, since this causes tests on Windows to fail, more investigation is required. I hope that this is a problem with the tests, and not indicative of deeper issues with courgette/bsdiff.
huangs@chromium.org changed reviewers: + huangs@chromium.org
Looked into it (thanks for Python Courgette, heh) and found cause of bug. Please apply and test! https://codereview.chromium.org/2769353003/diff/1/courgette/third_party/bsdif... File courgette/third_party/bsdiff/bsdiff_apply.cc (right): https://codereview.chromium.org/2769353003/diff/1/courgette/third_party/bsdif... courgette/third_party/bsdiff/bsdiff_apply.cc:99: const uint8_t* extra_position = extra_start; Need to add: extra_bytes->Skip(extra_bytes->Remaining()); Otherwise we never consume |extra_bytes|, and on line 165 we'd get !extra_bytes->empty(), which leads to failure ().
The CQ bit was checked by waffles@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by waffles@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org, wfh@chromium.org Link to the patchset: https://codereview.chromium.org/2769353003/#ps20001 (title: "Through #11")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491061347341000,
"parent_rev": "42820a412447065d7db96f10d7db2f3b61de2410", "commit_rev":
"761ab5e1b8a8e5d24200753b340250416c9b6a61"}
Message was sent while issue was closed.
Description was changed from ========== Return BSPatch value (previously, was ignored). BUG=705036 ========== to ========== Return BSPatch value (previously, was ignored). BUG=705036 Review-Url: https://codereview.chromium.org/2769353003 Cr-Commit-Position: refs/heads/master@{#461326} Committed: https://chromium.googlesource.com/chromium/src/+/761ab5e1b8a8e5d24200753b3402... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/761ab5e1b8a8e5d24200753b3402... |
