third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp - Issue 2769353002: Only create sticky position constraints for constrained sticky position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)

Patch Set: Merge with master. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

index d3889b9c879c8ef9142a429764b90dfcc6537d1e..4a766ef28aded31394077f4a05a8e8b202027d55 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

@@ -104,7 +104,7 @@ void CompositingInputsUpdater::UpdateRecursive(PaintLayer* layer,

const PaintLayer* previous_overflow_layer = layer->AncestorOverflowLayer();

layer->UpdateAncestorOverflowLayer(info.last_overflow_clip_layer);

if (info.last_overflow_clip_layer && layer->NeedsCompositingInputsUpdate() &&

- layer->GetLayoutObject().Style()->GetPosition() == EPosition::kSticky) {

+ layer->GetLayoutObject().Style()->HasStickyConstrainedPosition()) {

if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {

if (info.last_overflow_clip_layer != previous_overflow_layer) {

// Old ancestor scroller should no longer have these constraints.