Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)
Patch Set: Set dependent patch. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
index 53d5dfb1acd5d8d7b2625c133039496d26ee4999..3b4e62297f3ea08908763c4f1925f3685fec791b 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
@@ -101,7 +101,7 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,
const PaintLayer* previousOverflowLayer = layer->ancestorOverflowLayer();
layer->updateAncestorOverflowLayer(info.lastOverflowClipLayer);
if (info.lastOverflowClipLayer && layer->needsCompositingInputsUpdate() &&
- layer->layoutObject().style()->position() == EPosition::kSticky) {
+ layer->layoutObject().style()->hasStickyConstrainedPosition()) {
chrishtr 2017/03/27 16:28:07 Which code clears out the sticky position constrai
flackr 2017/04/07 18:15:45 LayoutBoxModelObject::styleDidChange checks if the
if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
if (info.lastOverflowClipLayer != previousOverflowLayer) {
// Old ancestor scroller should no longer have these constraints.

Powered by Google App Engine
This is Rietveld 408576698