third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2769353002: Only create sticky position constraints for constrained sticky position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)

Patch Set: Set dependent patch. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index a67d5daa6b6ed92a786f29761a9469fa43a62f88..3488284cc03b1e07082b189d74f8bdce3af6f4e9 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -294,7 +294,7 @@ void CompositedLayerMapping::updateBackdropFilters(const ComputedStyle& style) {

void CompositedLayerMapping::updateStickyConstraints(

const ComputedStyle& style,

const PaintLayer* compositingContainer) {

- bool sticky = style.position() == EPosition::kSticky;

+ bool sticky = style.hasStickyConstrainedPosition();

const PaintLayer* ancestorOverflowLayer =

m_owningLayer.ancestorOverflowLayer();

// TODO(flackr): Do we still need this?