third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2769353002: Only create sticky position constraints for constrained sticky position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)

Patch Set: Set dependent patch. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 774792307321d67b7e0512babcf8a92ef6884c45..af21d603ccc5819875bc89d3525999f6c952955c 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -1743,7 +1743,8 @@ bool FrameView::invalidateViewportConstrainedObjects() {

for (const auto& viewportConstrainedObject : *m_viewportConstrainedObjects) {

LayoutObject* layoutObject = viewportConstrainedObject;

LayoutItem layoutItem = LayoutItem(layoutObject);

- ASSERT(layoutItem.style()->hasViewportConstrainedPosition());

+ DCHECK(layoutItem.style()->hasViewportConstrainedPosition() ||

+ layoutItem.style()->hasStickyConstrainedPosition());

ASSERT(layoutItem.hasLayer());

PaintLayer* layer = LayoutBoxModel(layoutItem).layer();