Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)
Patch Set: Set dependent patch. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1725 matching lines...) Expand 10 before | Expand all | Expand 10 after
1736 return true; 1736 return true;
1737 } 1737 }
1738 return false; 1738 return false;
1739 } 1739 }
1740 1740
1741 bool FrameView::invalidateViewportConstrainedObjects() { 1741 bool FrameView::invalidateViewportConstrainedObjects() {
1742 bool fastPathAllowed = true; 1742 bool fastPathAllowed = true;
1743 for (const auto& viewportConstrainedObject : *m_viewportConstrainedObjects) { 1743 for (const auto& viewportConstrainedObject : *m_viewportConstrainedObjects) {
1744 LayoutObject* layoutObject = viewportConstrainedObject; 1744 LayoutObject* layoutObject = viewportConstrainedObject;
1745 LayoutItem layoutItem = LayoutItem(layoutObject); 1745 LayoutItem layoutItem = LayoutItem(layoutObject);
1746 ASSERT(layoutItem.style()->hasViewportConstrainedPosition()); 1746 DCHECK(layoutItem.style()->hasViewportConstrainedPosition() ||
1747 layoutItem.style()->hasStickyConstrainedPosition());
1747 ASSERT(layoutItem.hasLayer()); 1748 ASSERT(layoutItem.hasLayer());
1748 PaintLayer* layer = LayoutBoxModel(layoutItem).layer(); 1749 PaintLayer* layer = LayoutBoxModel(layoutItem).layer();
1749 1750
1750 if (layer->isPaintInvalidationContainer()) 1751 if (layer->isPaintInvalidationContainer())
1751 continue; 1752 continue;
1752 1753
1753 if (layer->subtreeIsInvisible()) 1754 if (layer->subtreeIsInvisible())
1754 continue; 1755 continue;
1755 1756
1756 // invalidate even if there is an ancestor with a filter that moves pixels. 1757 // invalidate even if there is an ancestor with a filter that moves pixels.
(...skipping 3500 matching lines...) Expand 10 before | Expand all | Expand 10 after
5257 void FrameView::setAnimationHost( 5258 void FrameView::setAnimationHost(
5258 std::unique_ptr<CompositorAnimationHost> host) { 5259 std::unique_ptr<CompositorAnimationHost> host) {
5259 m_animationHost = std::move(host); 5260 m_animationHost = std::move(host);
5260 } 5261 }
5261 5262
5262 LayoutUnit FrameView::caretWidth() const { 5263 LayoutUnit FrameView::caretWidth() const {
5263 return LayoutUnit(getHostWindow()->windowToViewportScalar(1)); 5264 return LayoutUnit(getHostWindow()->windowToViewportScalar(1));
5264 } 5265 }
5265 5266
5266 } // namespace blink 5267 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698