Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2769343002: Fix BUILD.gn and file existence inconsistency. (Closed)

Created:
3 years, 9 months ago by hidehiko
Modified:
3 years, 9 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, darin (slow to review), davemoore+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BUILD.gn and file existence inconsistency. Some files are missing in BUILD.gn. This CL updates BUILD.gn to include them, or removes the file if it is just stale. BUG=none TEST=Ran bots. Review-Url: https://codereview.chromium.org/2769343002 Cr-Commit-Position: refs/heads/master@{#459704} Committed: https://chromium.googlesource.com/chromium/src/+/9e4242231a21fb5ebdc990ad3cbc50b9afdf00d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D components/arc/common/input.mojom View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
hidehiko
PTAL. lhchavez@: components/arc, c/b/c/arc OWNER. dcheng@: mojom OWNER. cf) https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/1kK45mVemBc/cd6G6qDxBQAJ Best regards, - hidehiko
3 years, 9 months ago (2017-03-24 03:50:56 UTC) #4
dcheng
rs lgtm for mojom
3 years, 9 months ago (2017-03-24 04:33:28 UTC) #7
hidehiko
On 2017/03/24 04:33:28, dcheng wrote: > rs lgtm for mojom Thank you, dcheng@. PTAL, Luis. ...
3 years, 9 months ago (2017-03-24 04:59:23 UTC) #8
Luis Héctor Chávez
lgtm
3 years, 9 months ago (2017-03-24 16:35:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769343002/1
3 years, 9 months ago (2017-03-27 02:06:46 UTC) #11
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-27 03:08:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769343002/1
3 years, 9 months ago (2017-03-27 04:55:36 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 05:00:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e4242231a21fb5ebdc990ad3cbc...

Powered by Google App Engine
This is Rietveld 408576698