DevTools: Display a warning when trying to open untrusted frontend

DevTools: Display a warning when trying to open untrusted frontend.

When Chrome is trying to inspect a page on a connected Android device the DevTools frontend is fetched from a URL supplied by the remote browser.
Currently Chrome would crash if this URL is not pointing to a trusted source. For instance, this happens when trying to inspect a page in ContentShell.

This patch removes the CHECKs and displays a text warning instead.

BUG=295979
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229371

[pfeldman, 2013-10-17 11:35:06]

lgtm

[commit-bot: I haz the power, 2013-10-17 12:10:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/27693002/1

[commit-bot: I haz the power, 2013-10-17 12:45:56]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Vladislav Kaznacheev, 2013-10-17 13:10:22]

Hello Bernhard,

Please review this change to devtools_ui.cc

Thanks,

  Vlad

[Bernhard Bauer, 2013-10-17 13:36:34]

LGTM, but a better description would be nice. That this CL is about a crash when
inspecting content shell on Android should be clear from the linked bug, and
that it fixes the crash is obvious too (y'know, instead of making it worse ;-)
). Ideally, the description would say what you are changing (not what effect it
has), and why this is necessary (i.e. what's going wrong in the current state).

[Vladislav Kaznacheev, 2013-10-17 14:40:40]

On 2013/10/17 13:36:34, Bernhard Bauer wrote:
> LGTM, but a better description would be nice. That this CL is about a crash
when
> inspecting content shell on Android should be clear from the linked bug, and
> that it fixes the crash is obvious too (y'know, instead of making it worse ;-)
> ). Ideally, the description would say what you are changing (not what effect
it
> has), and why this is necessary (i.e. what's going wrong in the current
state).

Thanks for the comment! I started rewriting the description and realized that I
should
have removed the other CHECK in this function as well. This way no remote
browser ever
can crash a desktop browser.

[Bernhard Bauer, 2013-10-17 14:44:42]

Thanks! That's a lot nicer.

[commit-bot: I haz the power, 2013-10-17 14:53:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/27693002/12001

[commit-bot: I haz the power, 2013-10-18 01:53:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/27693002/12001

[commit-bot: I haz the power, 2013-10-18 12:12:04]

Change committed as 229371