Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 27693002: DevTools: Display a warning when trying to open untrusted frontend (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed the other CHECK Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/devtools_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 8c13a6d83736a0e38608abf5d782f9c9a0a25d6a..83fa9b4729dfab3520745e5df12b719638d58a26 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -622,6 +622,9 @@ GURL DevToolsWindow::GetDevToolsURL(Profile* profile,
DevToolsDockSide dock_side,
bool shared_worker_frontend,
bool external_frontend) {
+ if (base_url.SchemeIs("data"))
+ return base_url;
+
std::string frontend_url(
base_url.is_empty() ? chrome::kChromeUIDevToolsURL : base_url.spec());
ThemeService* tp = ThemeServiceFactory::GetForProfile(profile);
« no previous file with comments | « no previous file | chrome/browser/ui/webui/devtools_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698