Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2769273002: Make the chrome://signin-error accessiable by the incogtino System Profile. (Closed)

Created:
3 years, 9 months ago by zmin
Modified:
3 years, 9 months ago
Reviewers:
xiyuan, msarda
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the chrome://signin-error accessiable by the incogtino System Profile. chrome://signin-error will be used by the profile of UserManager when force-sign-in policy is enabled so that the sign in error can be shown without opening browser window. Before: https://drive.google.com/open?id=0B7mk_V3OvgKRREY3cTBKSjdxSGc After: https://drive.google.com/open?id=0B7mk_V3OvgKRbFUwRmt4VVFRZ2c BUG=642059 BUG=679265 Review-Url: https://codereview.chromium.org/2769273002 Cr-Commit-Position: refs/heads/master@{#459436} Committed: https://chromium.googlesource.com/chromium/src/+/82a6458a23cf1be17524e2d329e8f1c5668acb22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
msarda
lgtm
3 years, 9 months ago (2017-03-24 11:33:56 UTC) #7
zmin
+xiyuan Hi xiyuan, Can you review this CL please? Owen
3 years, 9 months ago (2017-03-24 14:58:06 UTC) #9
xiyuan
lgtm
3 years, 9 months ago (2017-03-24 15:24:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769273002/1
3 years, 9 months ago (2017-03-24 15:47:25 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 15:53:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82a6458a23cf1be17524e2d329e8...

Powered by Google App Engine
This is Rietveld 408576698