Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2769243002: Adjust initial activation/focus Task Manager/Views TableView. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust initial activation/focus Task Manager/Views TableView. In the task manager the table no longer has initial focus. When you open the task manager, you'll need to press tab to focus the table. When a TableView is focused it will activate the first row if no row is already active. BUG=702489 Review-Url: https://codereview.chromium.org/2769243002 Cr-Commit-Position: refs/heads/master@{#459825} Committed: https://chromium.googlesource.com/chromium/src/+/2fc3ba8587526eb5e5f7455ca463b0c166b1ee95

Patch Set 1 #

Total comments: 4

Patch Set 2 : sky review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M chrome/browser/ui/views/task_manager_view.h View 1 1 chunk +0 lines, -1 line 2 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/table/table_view.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Evan Stade
3 years, 9 months ago (2017-03-23 16:54:51 UTC) #3
sky
https://codereview.chromium.org/2769243002/diff/1/chrome/browser/ui/views/task_manager_view.cc File chrome/browser/ui/views/task_manager_view.cc (right): https://codereview.chromium.org/2769243002/diff/1/chrome/browser/ui/views/task_manager_view.cc#newcode165 chrome/browser/ui/views/task_manager_view.cc:165: return nullptr; ? https://codereview.chromium.org/2769243002/diff/1/ui/views/controls/table/table_view.cc File ui/views/controls/table/table_view.cc (right): https://codereview.chromium.org/2769243002/diff/1/ui/views/controls/table/table_view.cc#newcode630 ui/views/controls/table/table_view.cc:630: ...
3 years, 9 months ago (2017-03-23 17:50:17 UTC) #4
Evan Stade
https://codereview.chromium.org/2769243002/diff/1/chrome/browser/ui/views/task_manager_view.cc File chrome/browser/ui/views/task_manager_view.cc (right): https://codereview.chromium.org/2769243002/diff/1/chrome/browser/ui/views/task_manager_view.cc#newcode165 chrome/browser/ui/views/task_manager_view.cc:165: return nullptr; On 2017/03/23 17:50:17, sky wrote: > ? ...
3 years, 9 months ago (2017-03-23 22:56:26 UTC) #5
sky
https://codereview.chromium.org/2769243002/diff/20001/chrome/browser/ui/views/task_manager_view.h File chrome/browser/ui/views/task_manager_view.h (left): https://codereview.chromium.org/2769243002/diff/20001/chrome/browser/ui/views/task_manager_view.h#oldcode57 chrome/browser/ui/views/task_manager_view.h:57: views::View* GetInitiallyFocusedView() override; How come we no longer need ...
3 years, 9 months ago (2017-03-24 02:23:51 UTC) #10
Evan Stade
https://codereview.chromium.org/2769243002/diff/20001/chrome/browser/ui/views/task_manager_view.h File chrome/browser/ui/views/task_manager_view.h (left): https://codereview.chromium.org/2769243002/diff/20001/chrome/browser/ui/views/task_manager_view.h#oldcode57 chrome/browser/ui/views/task_manager_view.h:57: views::View* GetInitiallyFocusedView() override; On 2017/03/24 02:23:50, sky wrote: > ...
3 years, 9 months ago (2017-03-27 15:17:09 UTC) #11
sky
Ok, LGTM
3 years, 9 months ago (2017-03-27 16:11:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769243002/20001
3 years, 8 months ago (2017-03-27 16:46:50 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-27 18:02:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fc3ba8587526eb5e5f7455ca463...

Powered by Google App Engine
This is Rietveld 408576698