Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2769233003: [Offline pages] Ensuring tasks scheduled through GCM NM are persisted (Closed)

Created:
3 years, 9 months ago by fgorski
Modified:
3 years, 9 months ago
Reviewers:
dewittj
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Ensuring tasks scheduled through GCM NM are persisted We are currently not persisting tasks scheduled through GCM Network Manager, which means requests to offline pages in the background will not be resumed after a device restart. This patch fixes the issue. BUG=704610 Review-Url: https://codereview.chromium.org/2769233003 Cr-Commit-Position: refs/heads/master@{#459174} Committed: https://chromium.googlesource.com/chromium/src/+/0c1ab0868b12be571311df463894f06e47c8e62a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundGcmScheduler.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fgorski
PTAL
3 years, 9 months ago (2017-03-23 18:03:33 UTC) #2
dewittj
lgtm
3 years, 9 months ago (2017-03-23 18:05:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769233003/1
3 years, 9 months ago (2017-03-23 19:15:52 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 19:24:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c1ab0868b12be571311df463894...

Powered by Google App Engine
This is Rietveld 408576698