Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2769223004: Fix tests to verify defaultArgListString specified as null are null. (Closed)

Created:
3 years, 9 months ago by pquitslund
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix tests to verify defaultArgListString specified as null are null. * introduces a sentinel default value to ensure that we know when asserting if `null` was specified or the result of an excluded optional arg BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/5a237935f08e283060e0985bd66ff9f09c342e3b

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 6 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
It turns out that we only handle Lists when generating default args so the case ...
3 years, 9 months ago (2017-03-24 17:56:36 UTC) #2
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-24 18:04:43 UTC) #3
pquitslund
3 years, 9 months ago (2017-03-24 18:53:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5a237935f08e283060e0985bd66ff9f09c342e3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698