Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 2769223004: Fix tests to verify defaultArgListString specified as null are null. (Closed)
Patch Set: cleanup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index 1ded0a58a135277d6ce4bf6aeefcf2cb32b2be98..67baee0e442c60d3810f5bb65ac9890fc305dad6 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -37,6 +37,7 @@ int suggestionComparator(CompletionSuggestion s1, CompletionSuggestion s2) {
}
abstract class DartCompletionContributorTest extends AbstractContextTest {
+ static const String _UNCHECKED = '__UNCHECKED__';
Index index;
SearchEngineImpl searchEngine;
String testFile = '/completionTest.dart';
@@ -119,7 +120,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
int elemOffset,
String paramName,
String paramType,
- String defaultArgListString,
+ String defaultArgListString: _UNCHECKED,
List<int> defaultArgumentListTextRanges}) {
CompletionSuggestion cs =
getSuggest(completion: completion, csKind: csKind, elemKind: elemKind);
@@ -157,7 +158,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
if (paramType != null) {
expect(cs.parameterType, paramType);
}
- if (defaultArgListString != null) {
+ if (defaultArgListString != _UNCHECKED) {
expect(cs.defaultArgumentListString, defaultArgListString);
}
if (defaultArgumentListTextRanges != null) {
@@ -210,7 +211,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
{int relevance: DART_RELEVANCE_DEFAULT,
String importUri,
int elemOffset,
- String defaultArgListString,
+ String defaultArgListString: _UNCHECKED,
List<int> defaultArgumentListTextRanges}) {
CompletionSuggestion cs = assertSuggest(name,
relevance: relevance,
@@ -274,7 +275,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
bool isDeprecated: false,
int relevance: DART_RELEVANCE_DEFAULT,
String importUri,
- String defaultArgListString,
+ String defaultArgListString: _UNCHECKED,
List<int> defaultArgumentListTextRanges}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
@@ -370,7 +371,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
String importUri,
CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
bool isDeprecated: false,
- String defaultArgListString,
+ String defaultArgListString: _UNCHECKED,
List<int> defaultArgumentListTextRanges}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698