cc: If SetDeferCommits(true) happens inside the main frame, abort it.

cc: If SetDeferCommits(true) happens inside the main frame, abort it.

During the main frame, the embedder may decide it doesn't want to
commit anymore, and call SetDeferCommits(true). By continuing to
commit at this point we will submit state that it did not intend,
which in the case of the ui::Compositor would cause guttering from
resize, for example.

This adds an additional early out to abort commit after the
BeginMainFrame steps, but before UpdateLayers, if SetDeferCommits(true)
happened in the meantime. The abort will DidBeginMainFrame() to be
well paired with WillBeginMainFrame() but does not report DidCommit()
since the commit is aborted and we'll try again later.

R=enne@chromium.org
BUG=704928
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2769213006
Cr-Commit-Position: refs/heads/master@{#459775}
Committed: https://chromium.googlesource.com/chromium/src/+/97660d9bcf2f675cae26595987837c4fe67e8d97

[danakj, 2017-03-24 18:43:29]

Description was changed from

==========
cc: If SetDeferCommits(true) happens inside the main frame, abort it.

During the main frame, the embedder may decide it doesn't want to
commit anymore, and call SetDeferCommits(true). By continuing to
commit at this point we will submit state that it did not intend,
which in the case of the ui::Compositor would cause guttering from
resize, for example.

This adds an additional early out to abort commit after the
BeginMainFrame steps, but before UpdateLayers, if SetDeferCommits(true)
happened in the meantime. The abort will DidBeginMainFrame() to be
well paired with WillBeginMainFrame() but does not report DidCommit()
since the commit is aborted and we'll try again later.

R=enne@chromium.org
BUG=704928
==========

to

==========
cc: If SetDeferCommits(true) happens inside the main frame, abort it.

During the main frame, the embedder may decide it doesn't want to
commit anymore, and call SetDeferCommits(true). By continuing to
commit at this point we will submit state that it did not intend,
which in the case of the ui::Compositor would cause guttering from
resize, for example.

This adds an additional early out to abort commit after the
BeginMainFrame steps, but before UpdateLayers, if SetDeferCommits(true)
happened in the meantime. The abort will DidBeginMainFrame() to be
well paired with WillBeginMainFrame() but does not report DidCommit()
since the commit is aborted and we'll try again later.

R=enne@chromium.org
BUG=704928
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-03-24 18:46:48]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 18:47:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:06:34]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-03-26 23:50:06]

lgtm

https://codereview.chromium.org/2769213006/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/2769213006/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:2759: // we don't leave any weird states
around if we never allow the commit
Thanks for testing both of these states.  :D

https://codereview.chromium.org/2769213006/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:2775: // Wait to see if the commit happens.
It's possible the deferred
I looked at TestHooks and LayerTreeTest, but it doesn't seem like there's
anything there that would happen synchronously that you could assert
allow_commits_ inside of, like UpdateLayers or NotifyReadyToCommit.  I think
this is probably good enough, but it seems like it could be more robust if we
added more hooks for an event that you knew would happen synchronously if the
commit wasn't deferred.  That would also let you not have to wait, as you could
just post an event to EndTest to run immediately.

[enne (OOO), 2017-03-26 23:50:15]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-03-26 23:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 00:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 00:56:43]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[enne (OOO), 2017-03-27 13:14:28]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-03-27 13:14:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 14:11:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490620468871030,
"parent_rev": "d218e41ed36ca915714e11a234e36bf9551d0be9", "commit_rev":
"97660d9bcf2f675cae26595987837c4fe67e8d97"}

[commit-bot: I haz the power, 2017-03-27 14:12:38]

Description was changed from

==========
cc: If SetDeferCommits(true) happens inside the main frame, abort it.

During the main frame, the embedder may decide it doesn't want to
commit anymore, and call SetDeferCommits(true). By continuing to
commit at this point we will submit state that it did not intend,
which in the case of the ui::Compositor would cause guttering from
resize, for example.

This adds an additional early out to abort commit after the
BeginMainFrame steps, but before UpdateLayers, if SetDeferCommits(true)
happened in the meantime. The abort will DidBeginMainFrame() to be
well paired with WillBeginMainFrame() but does not report DidCommit()
since the commit is aborted and we'll try again later.

R=enne@chromium.org
BUG=704928
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: If SetDeferCommits(true) happens inside the main frame, abort it.

During the main frame, the embedder may decide it doesn't want to
commit anymore, and call SetDeferCommits(true). By continuing to
commit at this point we will submit state that it did not intend,
which in the case of the ui::Compositor would cause guttering from
resize, for example.

This adds an additional early out to abort commit after the
BeginMainFrame steps, but before UpdateLayers, if SetDeferCommits(true)
happened in the meantime. The abort will DidBeginMainFrame() to be
well paired with WillBeginMainFrame() but does not report DidCommit()
since the commit is aborted and we'll try again later.

R=enne@chromium.org
BUG=704928
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2769213006
Cr-Commit-Position: refs/heads/master@{#459775}
Committed:
https://chromium.googlesource.com/chromium/src/+/97660d9bcf2f675cae2659598783...
==========

[commit-bot: I haz the power, 2017-03-27 14:12:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97660d9bcf2f675cae2659598783...