Adds kWillProcessAccelerator_KeyEventProperty

Adds kWillProcessAccelerator_KeyEventProperty

Ash sets this on KeyEvents that ash has an accelerator for and that
ash doesn't process immediately. This allows chrome to not forward
these events to the renderer so that ash will end up processing them
(in certain situations).

BUG=701815
TEST=covered by tests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2769213005
Cr-Commit-Position: refs/heads/master@{#459484}
Committed: https://chromium.googlesource.com/chromium/src/+/62349ad779505d73be7c1dbd3db83dc9a38dc99f

[sky, 2017-03-24 15:05:36]

Description was changed from

==========
Adds kWillProcessAccelerator_KeyEventProperty

Ash sets this on KeyEvents that ash has an accelerator for and that
ash doesn't process immediately. This allows chrome to not forward
these events to the renderer so that ash will end up processing them
(in certain situations).

BUG=701815
TEST=covered by tests
R=sadrul@chromium.org
==========

to

==========
Adds kWillProcessAccelerator_KeyEventProperty

Ash sets this on KeyEvents that ash has an accelerator for and that
ash doesn't process immediately. This allows chrome to not forward
these events to the renderer so that ash will end up processing them
(in certain situations).

BUG=701815
TEST=covered by tests
R=sadrul@chromium.org
==========

[sky, 2017-03-24 15:05:36]

sky@chromium.org changed reviewers:
+ tsepez@chromium.org

[sky, 2017-03-24 15:05:36]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[sky, 2017-03-24 15:05:46]

tsepez: mojom
sadrul: the rest

[commit-bot: I haz the power, 2017-03-24 15:06:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 16:10:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 16:10:51]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2017-03-24 16:53:58]

lgtm

[sadrul, 2017-03-24 17:13:18]

This is for mash, right? How does chrome see the flag set by ash?

[sky, 2017-03-24 18:02:24]

The following is how chrome ends up seeing the key.

https://codereview.chromium.org/2769213005/diff/20001/ash/mus/accelerators/ac...
File ash/mus/accelerators/accelerator_controller_registrar.cc (right):

https://codereview.chromium.org/2769213005/diff/20001/ash/mus/accelerators/ac...
ash/mus/accelerators/accelerator_controller_registrar.cc:96:
(*properties)[mojom::kWillProcessAccelerator_KeyEventProperty] =
The |properties| supplied here are passed back to mus, which adds them to the
key event that chrome gets.

[sadrul, 2017-03-24 18:05:02]

lgtm

https://codereview.chromium.org/2769213005/diff/20001/ash/mus/accelerators/ac...
File ash/mus/accelerators/accelerator_controller_registrar.cc (right):

https://codereview.chromium.org/2769213005/diff/20001/ash/mus/accelerators/ac...
ash/mus/accelerators/accelerator_controller_registrar.cc:96:
(*properties)[mojom::kWillProcessAccelerator_KeyEventProperty] =
On 2017/03/24 18:02:23, sky wrote:
> The |properties| supplied here are passed back to mus, which adds them to the
> key event that chrome gets.

Ooh, right. This is only for pre-target accelerators, right? (and I guess in
mash, all accelerators are both pre/post target?)

[sky, 2017-03-24 18:11:54]

https://codereview.chromium.org/2769213005/diff/20001/ash/mus/accelerators/ac...
File ash/mus/accelerators/accelerator_controller_registrar.cc (right):

https://codereview.chromium.org/2769213005/diff/20001/ash/mus/accelerators/ac...
ash/mus/accelerators/accelerator_controller_registrar.cc:96:
(*properties)[mojom::kWillProcessAccelerator_KeyEventProperty] =
On 2017/03/24 18:05:01, sadrul wrote:
> On 2017/03/24 18:02:23, sky wrote:
> > The |properties| supplied here are passed back to mus, which adds them to
the
> > key event that chrome gets.
> 
> Ooh, right. This is only for pre-target accelerators, right?

Exactly. See line 75.

> (and I guess in
> mash, all accelerators are both pre/post target?)

Yep.

[sky, 2017-03-24 18:11:59]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-24 18:12:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:30:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490379119983330,
"parent_rev": "ad57bdd5ac229a7e0fb9b191413cc3057c6b6866", "commit_rev":
"62349ad779505d73be7c1dbd3db83dc9a38dc99f"}

[commit-bot: I haz the power, 2017-03-24 18:31:10]

Description was changed from

==========
Adds kWillProcessAccelerator_KeyEventProperty

Ash sets this on KeyEvents that ash has an accelerator for and that
ash doesn't process immediately. This allows chrome to not forward
these events to the renderer so that ash will end up processing them
(in certain situations).

BUG=701815
TEST=covered by tests
R=sadrul@chromium.org
==========

to

==========
Adds kWillProcessAccelerator_KeyEventProperty

Ash sets this on KeyEvents that ash has an accelerator for and that
ash doesn't process immediately. This allows chrome to not forward
these events to the renderer so that ash will end up processing them
(in certain situations).

BUG=701815
TEST=covered by tests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2769213005
Cr-Commit-Position: refs/heads/master@{#459484}
Committed:
https://chromium.googlesource.com/chromium/src/+/62349ad779505d73be7c1dbd3db8...
==========

[commit-bot: I haz the power, 2017-03-24 18:31:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/62349ad779505d73be7c1dbd3db8...