Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2769213004: Add accessibility ID to the icon next to autosuggest drop down for iPads. (Closed)

Created:
3 years, 9 months ago by lindsayw
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add accessibility ID to the icon next to autosuggest drop down for iPads. BUG=704158 Review-Url: https://codereview.chromium.org/2769213004 Cr-Commit-Position: refs/heads/master@{#459487} Committed: https://chromium.googlesource.com/chromium/src/+/ec4834647c37a0b0b3a6b7cfa0a45f590eb9bd46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lindsayw
3 years, 9 months ago (2017-03-23 21:52:46 UTC) #2
rohitrao (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-24 15:00:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769213004/1
3 years, 9 months ago (2017-03-24 17:56:12 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 18:39:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec4834647c37a0b0b3a6b7cfa0a4...

Powered by Google App Engine
This is Rietveld 408576698