Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 2769203003: [tracing] Fix import ordering in all files under tracing/ (Closed)

Created:
3 years, 9 months ago by hjd
Modified:
3 years, 9 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[tracing] Fix import ordering in all files under tracing/ There are a few files still with the wrong order. As discovered by doing: $ find tracing | grep 'html$' | while read f; do echo ' ' >> $f; done Then commiting and running: $ git cl presubmit Review-Url: https://codereview.chromium.org/2769203003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/052c435e5067f98c320b43688c0f96b1d24f3ecb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M tracing/tracing/base/event_target_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/cc/cc.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/time_to_object_instance_map_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/stack_frame_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/timing_tool_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/ui_state_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/about_tracing/profiling_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_tree_host_impl_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/gpu/gpu.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/system_stats/system_stats.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/scripting_control_test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
hjd
ptal, thanks! :)
3 years, 9 months ago (2017-03-24 11:00:27 UTC) #3
charliea (OOO until 10-5)
lgtm Thanks for doing this Hector!
3 years, 9 months ago (2017-03-27 14:08:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769203003/1
3 years, 9 months ago (2017-03-27 15:10:05 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 15:33:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698